Comments on: Updating timepickr

By: Danny

Danny — Fri, 01 Jul 2011 12:03:52 +0000

@Lucas:
That looks right. Can you put up a page with your code and I’ll try to look at it? Try it without the trigger option as well.
–Danny

By: Lucas

Lucas — Tue, 28 Jun 2011 11:31:03 +0000

This time picker functionality seems to be exactly what I need. However, it must be because I'm new to jQuery but I cannot get this to work. It's so frustrating. I was using the old timepickr but I really want to use this one. Here is my code: $(function(){ $('#timestart').timepickr({ trigger: 'focus' }); }); Am I referencing the field in the wrong manner? That's how I call timepickr from the original site and it works. It doesn't seem to work in this case. I am calling jquery-ui and everything. Thanks in advance for any tips and/or advice.

By: Shane Tomlinson

Shane Tomlinson — Fri, 05 Nov 2010 11:33:44 +0000

Hey Danny, great work here getting this updated for the newest jQuery/UI. I have a patch to your redo I’d like to submit back to you, it fixes some problems binding to blur to close the timepicker if trigger is set to something other than “click”, fixes a problem if the field does not have a value when the timepicker is instantiated but has a value when it is first shown, and finally fixes an issue I was seeing with the minutes row being shifted left in 24 hour mode whenever looking at hours 12-23. Could you get back to me with an address I can mail this to?

Thanks,
Shane

By: Danny

Danny — Sun, 31 Oct 2010 03:29:09 +0000

@Haso Keric:
Ah, got it. They created a real base class called $.Widget, so you had to change $.widget.prototype to $.Widget.prototype.
I updated my code; thanks!

I kept the CSS stuff in the .js file so I could keep it all in one file, though your approach is of course the correct one.
–Danny

By: Haso Keric

Haso Keric — Fri, 29 Oct 2010 15:08:43 +0000

It was minor changes the widget failed to destroy itself and cause a js error because apparently in 1.4.3 they changed the way this should be done… But ill keep improving it of course.. i also moved CSS stuff from .js to .css

keep an eye on it.. and contribute

By: Danny

Danny — Tue, 26 Oct 2010 03:29:55 +0000

@Haso:
I assume you updated the code for jQuery UI 1.8.5, though I can’t see any differences just glancing through the code. What changes did you make?
–Danny

By: Haso Keric

Haso Keric — Mon, 25 Oct 2010 21:25:19 +0000

Update the timepickr once again – http://github.com/hasokeric/jquery-timepickr/blob/master/jquery.timepickr.js

By: Danny

Danny — Thu, 21 Oct 2010 15:49:59 +0000

@Lucas:
Thanks! I don’t use ui.dialog, but others may find this useful.
Danny

By: Lucas G.

Lucas G. — Tue, 19 Oct 2010 13:54:44 +0000

Hello @Mario / @Danny

I have found some problems combining this with a jQuery dialog. This little change does the work for me:

From:

if (this.options.resetOnBlur) {
menu.find(‘li’).bind(‘mousedown.timepickr’, function() {
element.data(‘timepickr.initialValue’, element.val());
});
}

to:

if (this.options.resetOnBlur) {
menu.find(‘li’).bind(‘mousedown.timepickr’, function() {
element.data(‘timepickr.initialValue’, element.val());

ui.hide(); //Add this line
});
}

Hope this helps to anyone who may need it.

Regards.

By: Danny

Danny — Wed, 22 Sep 2010 15:40:28 +0000

@Vincenzo: There's no way to limit the range of hours as the plugin is currently written, but you could modify it: change the _getRanges12 or _getRanges24 functions to just the hours you want, then change the lines

			var dayHours   = hrs.find('li').slice(0, 12);
			var nightHours = hrs.find('li').slice(12, 24);

in _redraw to select the appropriate hours. Hope this helps, Danny